Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Correct remaining endianness issues #2729

Merged
merged 1 commit into from
May 3, 2023

Conversation

matoro
Copy link
Contributor

@matoro matoro commented Apr 29, 2023

Fixes the last two remaining test failures on big-endian. These operations were all already no-ops on little-endian, and unnecessarily byteswapped the IP addresses on big-endian.

Closes: #2697

@codecov-commenter
Copy link

Codecov Report

Merging #2729 (321e31c) into master (66c86b1) will increase coverage by 0.13%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2729      +/-   ##
==========================================
+ Coverage   66.84%   66.98%   +0.13%     
==========================================
  Files          99       99              
  Lines       20174    20166       -8     
==========================================
+ Hits        13486    13508      +22     
+ Misses       6688     6658      -30     
Impacted Files Coverage Δ
srtcore/common.cpp 34.92% <100.00%> (-2.40%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko added this to the v1.5.2 milestone May 2, 2023
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels May 2, 2023
srtcore/common.cpp Outdated Show resolved Hide resolved
Fixes the last two remaining test failures on big-endian.  These
operations were all already no-ops on little-endian, and unnecessarily
byteswapped the IP addresses on big-endian.

Closes: Haivision#2697
@maxsharabayko maxsharabayko merged commit 3cefede into Haivision:master May 3, 2023
@maxsharabayko
Copy link
Collaborator

Thank you for the fix, @matoro!

@matoro
Copy link
Contributor Author

matoro commented May 3, 2023

@maxsharabayko Would you be willing to accept a PR for for #2702 using https://github.com/marketplace/actions/run-on-architecture ?

@maxsharabayko
Copy link
Collaborator

@matoro Yep, that would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Test failures on big-endian
3 participants