[core] New implementation for the logging/formatting system #2955
Conversation
…pdated sfmt implementation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…adowed local variables
maxsharabayko
added
Type: Maintenance
srtcore/sfmt.h
Outdated
There was a problem hiding this comment.
Please use a unique name to avoid conflicts with the fmt library.
For example, srt_format.h.
The same for namespaces used. The main one must be srt. Then maybe again not fmt but something more unique, unless fmt library can be used instead if enabled in CMake.
There was a problem hiding this comment.
It doesn't actually, this is distributed in my fork of the {fmt} library and there are no conflicting names there (and its license is PD, so it can be freely copied). Although I understand that to really avoid any potential conflicts in the future it should use different naming. I would keep the "sfmt" name at least as a part of the filename. As for the namespace, I think it may simply go whole into srt namespace, I think there are no name conflicts against it.
srtcore/sfmt.h
Outdated
| @@ -0,0 +1,1047 @@ | |||
| // Formatting library for C++ - C++03 compat version of on-demand tagged format API. | |||
| // | |||
| // Copyright (c) 2024 - present, Mikołaj Małecki | |||
There was a problem hiding this comment.
Copyright - Haivision. Authors: Mikołaj Małecki
There was a problem hiding this comment.
Well, I'm not sure about that. Although it should be mentioned that it is copied from an open-source library distributed with PD license.
| const internal::form_memory_buffer<2> seol ("\n"); | ||
|
|
||
| // Another manipulator. You can add yourself others the same way. | ||
| const struct os_flush_manip {} sflush; |
Check notice
Code scanning / CodeQL
Unused static variable Note
| void open(const std::string& name, const std::string& mode = "") | ||
| { | ||
| if (mode == "") | ||
| in = std::fopen(name.c_str(), "w"); |
Check failure
Code scanning / CodeQL
File created without restricting permissions High
This reimplements the logging system by replacing the iostream-based system with a custom class that does formatting through snprintf. The use of
std::ostringstreamhas been replaced withfmt::obufstream, which should do the same string building.Other changes, beside replacement of state tags for formatting with the use of
sfmt, are explicit type conversions limited to those that can be handled by snprintf.