Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraalJS dependency #111

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Update GraalJS dependency #111

merged 8 commits into from
Aug 28, 2023

Conversation

BarrensZeppelin
Copy link
Contributor

@BarrensZeppelin BarrensZeppelin commented Aug 17, 2023 •
edited
Loading

I'm attempting to make nodeprof work on newer versions of GraalJS.
Currently I've updated GraalJS to version 23.3.3.

The changes are relatively simple, the tests pass, and I've run some of our dynamic analyses using the updated version without issues, so I think the risk of breaking everything is quite small.
Still, it would be nice if more users could test it out.
I don't think there's an official communication channel for nodeprof, so I'm just tagging some people that have opened issues recently. If you have the time to test the changes, it would very helpful. 🙂

@mwaldrich @MadhuNimmo @Soulike @alexjordan

@Haiyang-Sun
Copy link
Owner

@BarrensZeppelin Many thanks for the contribution. It is great that we can get some help from the open-source community to help maintain NodeProf and keep it up-to-date. I have created a new branch (graalvm-22.1.0) based on what it is now on master and will do a new release based on that.
Let's try to get this merged to master and we can do another big release once it's stable.

@Haiyang-Sun Haiyang-Sun self-requested a review August 23, 2023 02:56
Haiyang-Sun
Haiyang-Sun reviewed Aug 23, 2023
View reviewed changes
Copy link
Owner

@Haiyang-Sun Haiyang-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left a few comments.

mx.nodeprof/mx_nodeprof.py Outdated Show resolved Hide resolved
src/ch.usi.inf.nodeprof/src/ch/usi/inf/nodeprof/jalangi/factory/AbstractFactory.java Outdated Show resolved Hide resolved
@BarrensZeppelin
Copy link
Contributor Author

Thanks for the feedback. 🙂

Haiyang-Sun
Haiyang-Sun approved these changes Aug 25, 2023
View reviewed changes
Copy link
Owner

@Haiyang-Sun Haiyang-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for the contribution.

@Haiyang-Sun
Copy link
Owner

@BarrensZeppelin can you try mx checkstyle --primary and mx checkcopyrights-nodeprof? These checks are failing in the check

@BarrensZeppelin
Copy link
Contributor Author

The issues should be fixed now 🤞

I tried to set up checkstyle in my IDE through mx ideinit, but it must've not worked properly.

@BarrensZeppelin
Copy link
Contributor Author

BarrensZeppelin commented Aug 25, 2023 •
edited
Loading

Hmm, I'll have a look at the NPM test failure locally...

EDIT: Maybe test-npm should be added to test-all?

@BarrensZeppelin
Fix crash on binary 'in' operator
be52af3 
Since GraalJS 22.1, getNodeObject() for a JSBinaryNode can return null
if the node does not have a NodeInfo annotation, which the InNode
doesn't have.
@Haiyang-Sun
Copy link
Owner

EDIT: Maybe test-npm should be added to test-all?

Let's do that in a follow up.

@BarrensZeppelin
Copy link
Contributor Author

Well, now I'm at a loss.
I don't know why there's an implicit call to Object.create in minitests/exitException.js only when running in svm-mode.
I ran the rest of the suite locally, and it's the only test that fails. 🙃

@Haiyang-Sun
Copy link
Owner

Haiyang-Sun commented Aug 27, 2023 •
edited
Loading

@BarrensZeppelin How about skipping that unit test first, we can track that in a separate issue and follow up on that. Keeping the master up-to-date with the latest graal.js is more important in my opinion.

@BarrensZeppelin
Copy link
Contributor Author

Alright, I've added a temporary work-around for now.

Haiyang-Sun
Haiyang-Sun approved these changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@Haiyang-Sun Haiyang-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BarrensZeppelin Now that all tests are passing, let's merge the changes. Thanks for the fix!

@Haiyang-Sun Haiyang-Sun merged commit 4777c8e into Haiyang-Sun:master Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haiyang-Sun Haiyang-Sun Haiyang-Sun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BarrensZeppelin @Haiyang-Sun