accepting default app.yaml file #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haewoniee
force-pushed
the
feature/default-app-yaml-file
branch
from
a176d3e
to
624679a
Compare
HalfdanJ
reviewed
Apr 18, 2024
| @@ -15,6 +15,7 @@ export default function entrypoint(options = {}) { | |||
| useCloudTracing = false, | |||
| dependencies = {}, | |||
| nodejsRuntime = 18, | |||
| defaultYamlFile = "app.yaml" | |||
There was a problem hiding this comment.
I think it would make more sense to name the parameter something like 'appYamlFile' and not default, since the config overrides the default (which is app.yaml)
| if (existsSync("app.yaml")) { | ||
| builder.log.minor("Existing app.yaml found"); | ||
| yaml = YAML.parse(readFileSync("app.yaml").toString()); | ||
| if (existsSync(defaultYamlFile)) { |
There was a problem hiding this comment.
If a yaml file is specified i think the code should throw an error if the file is not found, otherwise it can probably be a bit confusing
There was a problem hiding this comment.
Although that might be a bit more complicated to get right. I'm fine either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#175