Skip to content
This repository has been archived by the owner on Feb 8, 2019. It is now read-only.

Register new notifications in the settings.json file #11

Open
HalleyInteractive opened this issue Jun 12, 2014 · 2 comments
Open

Register new notifications in the settings.json file #11

HalleyInteractive opened this issue Jun 12, 2014 · 2 comments

Comments

@HalleyInteractive
Copy link
Owner

Register every notification in the settings.json so the user has a history of it's notifications.

Maybe we can limit the number of notifications to 100.
HalleyInteractive added a commit that referenced this issue Jun 12, 2014
@HalleyInteractive
Added save function to settings file.
8112b08 
ConstructNotificaiton function adds the notification to the settingsFile.
#11
@HalleyInteractive
Copy link
Owner Author

Still need to limit the number of entries and retrieve the extension color.
Not sure if extension color should be saved in the settingsFile or a reference to the extension, in case the color changes.

@HalleyInteractive HalleyInteractive mentioned this issue Jun 18, 2014
Open
@GriffinSauce
Copy link
Collaborator

I would say reference the extension. Keep the control at the source.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HalleyInteractive @GriffinSauce