This allows matching a display by name or UUID -- helpful if two screens with the same name #1801

clarsen · 2018-05-26T03:46:17Z

No description provided.

cmsj · 2018-06-07T12:47:58Z

extensions/layout/init.lua

@@ -10,6 +10,7 @@ local fnutils = require("hs.fnutils")
 local screen = require("hs.screen")
 local window = require("hs.window")
 local application = require("hs.application")
+local spi = require("hs._asm.undocumented.spaces.internal")


The hs._asm.undocumented.spaces.internal module isn't shipped with Hammerspoon, so we can't include it in one of our modules.

Maybe I can revise so that caller should pass in an actually screen previously determined by hs._asm.undocumented.spaces.internal.UUIDforScreen that can be vetted by the existing code? I.e. no change really.

In other notes, I have a preprocessing enhancement for use of hs.layout that can deal with multi-monitors with layout specified like the example form below. Perhaps I should submit a separate issue to discuss possibly incorporating this into hs.layout?

oneMonitorDef = { { screen = "Color LCD"; display_uuid = "A1067B4B-926A-055F-C929-DD7875BE07A3"; }, } twoMonitorDef = { { screen = "Color LCD"; display_uuid = "A1067B4B-926A-055F-C929-DD7875BE07A3"; }, { screen = "DELL U3011"; display_uuid = "61346AEB-0959-1BE6-A8BE-36B9E98B97FC"; }, } windows = { { app = "Atom", title = ".*~/lsrc/data.and.reviews" oneMonitor = { geom = geoms.right75, screen_num = 1, space = 3 }, twoMonitor = { geom = geoms.right50, screen_num = 2, space = 1 }, }, ... }

FWIW it looks like the UUID is officially moving to being private API in 10.14. I'm also not convinced that it's properly unique - e.g. is the UUID stable across connections of the monitor?

My overall approach for hs.layout has always been to identify the monitors ahead of time - e.g. with two identical monitors I'd get hs.screen.primaryScreen() and then use :toEast() and :toWest() to determine which monitor is which, and pass them to hs.layout as leftMonitor and rightMonitor.

stickler-ci · 2018-10-22T20:17:41Z

extensions/layout/init.lua

@@ -151,11 +152,26 @@ function layout.apply(layout, windowTitleComparator)
        -- Find the destination display, if wanted
        if _row[3] then
            if type(_row[3]) == "string" then
-                local displays = fnutils.filter(screen.allScreens(), function(aScreen) return aScreen:name() == _row[3] end)
+            		-- first try match as UUID


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:41Z

extensions/layout/init.lua

@@ -151,11 +152,26 @@ function layout.apply(layout, windowTitleComparator)
        -- Find the destination display, if wanted
        if _row[3] then
            if type(_row[3]) == "string" then
-                local displays = fnutils.filter(screen.allScreens(), function(aScreen) return aScreen:name() == _row[3] end)
+            		-- first try match as UUID
+            		local displays = fnutils.filter(screen.allScreens(), function(aScreen) return spi.UUIDforScreen(aScreen) == _row[3] end)


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:41Z

extensions/layout/init.lua

                if displays then
-                    -- TODO: This is bogus, multiple identical monitors will be impossible to lay out
-                    display = displays[1]
+            		    display = displays[1]


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:41Z

extensions/layout/init.lua

-                    -- TODO: This is bogus, multiple identical monitors will be impossible to lay out
-                    display = displays[1]
+            		    display = displays[1]
+    		        else


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:42Z

extensions/layout/init.lua

-                    display = displays[1]
+            		    display = displays[1]
+    		        else
+    		            -- then try match as screen name


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:42Z

extensions/layout/init.lua

                end
+            		-- check if it matches a UUID instead
+            		if display == nil then


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:42Z

extensions/layout/init.lua

                end
+            		-- check if it matches a UUID instead
+            		if display == nil then
+                    for _, screen in pairs(hs.screen.allScreens()) do


(W431) shadowing upvalue 'screen' on line 10

stickler-ci · 2018-10-22T20:17:43Z

extensions/layout/init.lua

+            		if display == nil then
+                    for _, screen in pairs(hs.screen.allScreens()) do
+                        if _row[3] == spi.UUIDforScreen(screen) then
+    	                       display = screen


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:43Z

extensions/layout/init.lua

+                        if _row[3] == spi.UUIDforScreen(screen) then
+    	                       display = screen
+                        end
+            		    end


(W621) inconsistent indentation (SPACE followed by TAB)

stickler-ci · 2018-10-22T20:17:43Z

extensions/layout/init.lua

+    	                       display = screen
+                        end
+            		    end
+            		end


(W621) inconsistent indentation (SPACE followed by TAB)

cmsj · 2019-08-21T10:20:48Z

I'm gonna close this out, since it seems like there's no easy way forward.

asmagill · 2019-08-21T14:05:13Z

@cmsj, where did you come across the info regarding the uuid api becoming private in 10.14? If there is a list of expected deprecations available, it would be useful for me to review it closely as well.

And FWIW, if the only code being used from the spaces module is to get the screen's uuid, that specific code actually doesn't use any of the private API functions leveraged for that module --

static int screenUUID(lua_State *L) {
    [[LuaSkin shared] checkArgs:LS_TUSERDATA, USERDATA_TAG, LS_TBREAK] ;

    NSScreen* screen = get_screen_arg(L, 1);
    CGDirectDisplayID cgID = [[[screen deviceDescription] objectForKey:@"NSScreenNumber"] unsignedIntValue] ;

    CFUUIDRef   theUUID    = CGDisplayCreateUUIDFromDisplayID(cgID) ;
    if (theUUID) {
        CFStringRef UUIDString = CFUUIDCreateString(kCFAllocatorDefault, theUUID) ;
        [[LuaSkin shared] pushNSObject:(__bridge_transfer NSString *)UUIDString] ;
        CFRelease(theUUID) ;
    } else {
        lua_pushnil(L) ;
    }
    return 1 ;
}

Not sure if that changes anything but thought I'd point it out.

cmsj · 2019-08-21T14:29:49Z

huh, I think I noticed CGDisplayCreateUUIDFromDisplayID moving from one framework to another and misread that as a deprecation/removal. I've just added hs.screen:getUUID() which should help :)

asmagill · 2020-04-29T20:45:59Z

What is the status of this pull? hs.screen:getUUID() has been added, as noted above, so getting the UUID is now doable. What else is required?

latenitefilms · 2020-06-03T13:47:24Z

@clarsen - Do you have any interest in updating this code to use hs.screen:getUUID() (as opposed to hs._asm.undocumented.spaces.internal) or would you like me to give it a crack in another pull request? Either way, it would be good to close off this pull request, as it's been sitting here for quite some time now. Thanks!

Case Larsen added 2 commits April 9, 2018 13:07

deal with multiple displays, same name

fd72395

use display UUID instead of name as screen matcher.

0753320

cmsj requested changes Jun 7, 2018

View reviewed changes

clarsen and others added 3 commits October 22, 2018 10:09

sync

d04eaf8

deal with multiple displays, same name

471fc2e

adjust indenting

c7859d4

stickler-ci reviewed Oct 22, 2018

View reviewed changes

cmsj closed this Aug 21, 2019

cmsj reopened this Aug 21, 2019

cmsj added a commit that referenced this pull request Aug 21, 2019

Add hs.screen:getUUID(). Relates to #1801

697f941

asmagill closed this in 8ec10bf Sep 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

This allows matching a display by name or UUID -- helpful if two screens with the same name #1801

This allows matching a display by name or UUID -- helpful if two screens with the same name #1801

clarsen commented May 26, 2018

cmsj Jun 7, 2018

clarsen Jun 14, 2018

cmsj Jun 21, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

stickler-ci Oct 22, 2018

cmsj commented Aug 21, 2019

asmagill commented Aug 21, 2019

cmsj commented Aug 21, 2019

asmagill commented Apr 29, 2020

latenitefilms commented Jun 3, 2020

This allows matching a display by name or UUID -- helpful if two screens with the same name #1801

This allows matching a display by name or UUID -- helpful if two screens with the same name #1801

Conversation

clarsen commented May 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsj commented Aug 21, 2019

asmagill commented Aug 21, 2019

cmsj commented Aug 21, 2019

asmagill commented Apr 29, 2020

latenitefilms commented Jun 3, 2020