Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Provide functionality to hs.spaces for basic manipulation of desktop spaces #3154

Closed
wants to merge 4 commits into from

Conversation

asmagill
Copy link
Member

No description provided.

extensions/spaces/spaces.lua Outdated Show resolved Hide resolved
extensions/spaces/spaces.lua Outdated Show resolved Hide resolved
extensions/spaces/spaces.lua Show resolved Hide resolved
extensions/spaces/spaces.lua Show resolved Hide resolved
extensions/spaces/spaces.lua Outdated Show resolved Hide resolved
extensions/spaces/spaces.lua Outdated Show resolved Hide resolved
extensions/spaces/spaces.lua Outdated Show resolved Hide resolved
extensions/spaces/spaces.lua Show resolved Hide resolved
extensions/spaces/spaces.lua Outdated Show resolved Hide resolved
extensions/spaces/spaces.lua Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: pr-fix, pr-change, pr-feature, pr-maintenance

@asmagill
Copy link
Member Author

Ok, forgot that hitting return submitted a pull, not moved you to the comment field... At any rate, this is ready for review by a wider audience and consideration for including in core. I have minimized (but not entirely removed) the use of private APIs by utilizing hs.axuielement and the Dock application. This allows us to do some basic things like add/remove spaces, switch to them, etc. but at the cost of the same screen animations you would get by doing it by hand... still it's less jarring than the previous approach of having to kill and restart the Dock, and you can minimize the visual affect by reducing motion (see the documentation).

Regarding the name change of the dylib discussed #3094 (comment), I found that the cleanest approach was just to rename the spaceswatcher target to spaces_watcher and the internal linkages were updated automatically as far as I can determine.

I'm listing this as WIP rather than Review because I want to get @cmsj's input on the target (and thus library) name change and I want to review the docs a bit more, but I also wanted to put this out there for a wider review.

@asmagill
Copy link
Member Author

(I did still have to manually edit setup.lua, though)

@asmagill asmagill added the pr-feature Pull Request implementing a feature label Mar 13, 2022
@asmagill
Copy link
Member Author

And I'll deal with stickler after I get some sleep.

@github-actions
Copy link

github-actions bot commented Mar 13, 2022

View Test Results

    1 files      2 suites   18m 28s ⏱️
338 tests 290 ✔️ 48 💤 0

Results for commit 4ecd5ed.

♻️ This comment has been updated with latest results.

clean doc strings
remove managedScreenIsAnimating as it's unreliable and of limited use anyways
@asmagill
Copy link
Member Author

Pending @cmsj's approval on the renaming of the spaceswatcher target, and barring any unexpected problems reviewers might find, I consider this ready.

@asmagill asmagill changed the title [WIP] Provide functionality to hs.spaces for basic manipulation of desktop spaces [READY] Provide functionality to hs.spaces for basic manipulation of desktop spaces Mar 21, 2022
@cmsj
Copy link
Member

cmsj commented Mar 21, 2022

I've merged and pushed this manually, since it had a conflict with a recent setup.lua change.

1 similar comment
@cmsj
Copy link
Member

cmsj commented Mar 21, 2022

I've merged and pushed this manually, since it had a conflict with a recent setup.lua change.

@cmsj cmsj closed this Mar 21, 2022
@cmsj cmsj closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull Request implementing a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants