-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Provide functionality to hs.spaces for basic manipulation of desktop spaces #3154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: pr-fix, pr-change, pr-feature, pr-maintenance
Ok, forgot that hitting return submitted a pull, not moved you to the comment field... At any rate, this is ready for review by a wider audience and consideration for including in core. I have minimized (but not entirely removed) the use of private APIs by utilizing Regarding the name change of the I'm listing this as WIP rather than Review because I want to get @cmsj's input on the target (and thus library) name change and I want to review the docs a bit more, but I also wanted to put this out there for a wider review. |
(I did still have to manually edit |
And I'll deal with stickler after I get some sleep. |
clean doc strings remove managedScreenIsAnimating as it's unreliable and of limited use anyways
# Conflicts: # Hammerspoon/setup.lua
Pending @cmsj's approval on the renaming of the spaceswatcher target, and barring any unexpected problems reviewers might find, I consider this ready. |
I've merged and pushed this manually, since it had a conflict with a recent |
1 similar comment
I've merged and pushed this manually, since it had a conflict with a recent |
No description provided.