Gauge2 now works with any anglerange, min, and max #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, trying to use gauge2 with minimum values of nonzero severely impact the barlength improperly (despite the needle working fine). Additionally, angle ranges often were miscalculated when drawing the gauge fill, with a gradient stroke.
These adjustments have allowed me to create 90*, 180*, 270*, and 360* Gauge2 tiles with any minimum & maximum values.
(One request I would make, would be if you do a full 360* Gauge2 tile, that the text display of the value is dropped a bit, to be underneath the circle, rather than superimposed over it. This pull request does not have that functionality.)