Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Queue: Using Option "Clear All" does really clear ALL items, even those work in progress #2587

Closed
ischilling opened this issue Jan 17, 2020 · 2 comments
Labels

Comments

@ischilling
Copy link

Problem description:

In a currently running / started queue with completed, not yet started and currently work in progress queue item, clicking on Options - Clear All removes all queue items. So far, so good.

The problem is, it clears also the currently work in progress queue item. That this progress isn't halted yet is only indicated through the fact that the upper left button still shows "Pause Queue" instead of "Start Queue". Clicking the Pause Queue button does than behave as expected and the current work in progress is finished as usual.

However, if I click on Clear All, I expect

  • to get a warning that this would also clear the current work in progress - and kills it therefore - and informs me that there might be remains I have to take care of...
  • or more elegant, leaves the work in progress item where it is and does only clear all other items.

I personally would go for the ladder behavior.

HandBrake version (e.g., 1.3.0):

Nightly 20200115194359-1994200-master (2020011501)

Operating system and version (e.g., Ubuntu 19.10, macOS 10.15 Catalina, Windows 10 1909):

Most recent Windows 10 including all patches

Error message text and/or screenshot:

Please provide any error messages or screenshots that may help.

HandBrake Activity Log:

An Activity Log is required for support. Please read https://handbrake.fr/docs/en/latest/help/activity-log.html for more information.

Please replace this text with the Activity Log, or upload the log file to Github by dragging and dropping the file on this post.
Leave the ~ marks above and below.
@ischilling ischilling changed the title Major Bug: Queue: Using Option "Clear All" does really clear ALL items, even those work in progress Bug: Queue: Using Option "Clear All" does really clear ALL items, even those work in progress Jan 17, 2020
@ischilling
Copy link
Author

In addition, Clear All should also ask: "Are you sure to Clear All?" or something like this, independent on whether or not the bug is seen as such.

@sr55 sr55 added the Bug label Jan 18, 2020
@sr55
Copy link
Contributor

sr55 commented Jan 18, 2020

Fixed the issue where it cleared active jobs. This no longer happens.

In addition, Clear All should also ask: "Are you sure to Clear All?" or something like this, independent on whether or not the bug is seen as such.

It already does.

image

@sr55 sr55 closed this as completed in 97424db Jan 18, 2020
sr55 added a commit that referenced this issue Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants