Fix access to remote shares with gvfs 1.48 #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for the changes are explained in: https://gitlab.gnome.org/GNOME/gvfs/-/issues/515#note_919326
|
@jstebbins one for you and we may want to revist or closed #3164 if it's still relevant or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for the changes are explained in: https://gitlab.gnome.org/GNOME/gvfs/-/issues/515#note_919326
Before Posting:
Description of Change:
gvfs 1.48 has made a change to improve sandboxed performance when trying to access network shares. The reason for the changes are explained in: https://gitlab.gnome.org/GNOME/gvfs/-/issues/515#note_919326 and the upshot is we need to add "--filesystem=xdg-run/gvfsd", to the flatpak manifest. This does that.
For more context - there's a flathub wide tracker bug to update all developers on this before the change becomes widespread flathub/flathub#2180
Test on:
Tested on the latest fedora 34 beta.