Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker for applications using --filesystem=xdg-run/gvfs #2180

Open
26 of 34 tasks
Tracked by #16
hadess opened this issue Mar 26, 2021 · 19 comments
Open
26 of 34 tasks
Tracked by #16

Tracker for applications using --filesystem=xdg-run/gvfs #2180

hadess opened this issue Mar 26, 2021 · 19 comments
Labels
tracker A big list of things to track

Comments

@hadess
Copy link

hadess commented Mar 26, 2021

Flatpak documentation: https://docs.flatpak.org/en/latest/sandbox-permissions.html#gvfs-access

Starting with gvfs 1.48, GNOME gvfs daemons will use an on-disk socket to communicate with gvfsd so that it will be possible to talk to gvfs while disabling the network. However, for applications to be able to talk through that on-disk socket, they need to be able to access it.

If your application talks directly to gvfs daemon, for example to list mounts, and access optical discs, then you will need to modify your application's manifest to include access to the $XDG_RUNTIME_DIR/gvfsd. For example, for a JSON manifest:

         "--talk-name=org.gtk.vfs", "--talk-name=org.gtk.vfs.*",
        "--filesystem=xdg-run/gvfs", "--filesystem=xdg-run/gvfsd",

If your application doesn't need to talk to gvfs via D-Bus, then it doesn't need access to xdg-run/gvfsd.

If you tried to access files using gvfs, and gvfsd was inaccessible, this error would be returned:

Error while getting peer-to-peer dbus connection: Could not connect: No such file or directory
hadess added a commit to hadess/filter-flathub-repos that referenced this issue Mar 26, 2021
@hadess
Copy link
Author

hadess commented Mar 26, 2021

GNOME Videos (org.gnome.Totem) fixed in flathub/org.gnome.Totem#62

@Lctrs
Copy link

Lctrs commented Mar 27, 2021

com.axosoft.GitKraken fixed in flathub/com.axosoft.GitKraken@5f5685c.
org.gnome.NetworkDisplays fixed in flathub/org.gnome.NetworkDisplays@b190ce9.

@hadess
Copy link
Author

hadess commented Mar 27, 2021

Please be careful, if the application doesn't talk directly to gvfs, there's no need to add that hole. Eg. Krita doesn't need the change...

@gasinvein
Copy link
Member

Here is a complete list of apps with `--talk-name=org.gtk.vfs.*`, maybe it helps
com.abisource.AbiWord
com.axosoft.GitKraken
com.github.alainm23.byte
com.github.alainm23.planner
com.github.artemanufrij.playmymusic
com.github.birros.WebArchives
com.github.calo001.fondo
com.github.geigi.cozy
com.github.horaciodrs.tradesim
com.github.junrrein.PDFSlicer
com.github.louis77.tuner
com.github.mdh34.quickdocs
com.github.needleandthread.vocal
com.github.philip_scott.notes-up
com.github.PintaProject.Pinta
com.giuspen.cherrytree
com.lettier.movie-monad
com.neatdecisions.Detwinner
com.rawtherapee.RawTherapee
com.transmissionbt.Transmission
com.usebottles.bottles
com.xnview.XnViewMP
cz.zeropage.Formiko
de.create3000.titania
dev.tchx84.Portfolio
edu.stanford.Almond
fr.handbrake.ghb
io.atom.Atom
io.brackets.Brackets
io.github.celluloid_player.Celluloid
io.github.dfandrich.gpscorrelate
org.darktable.Darktable
org.entangle_photo.Manager
org.free_astro.siril
org.freefilesync.FreeFileSync
org.gimp.GIMP
org.glimpse_editor.Glimpse
org.gnome.baobab
org.gnome.Builder
org.gnome.ColorViewer
org.gnome.DejaDup
org.gnome.Evince
org.gnome.FileRoller
org.gnome.font-viewer
org.gnome.gedit
org.gnome.Lollypop
org.gnome.Music
org.gnome.NetworkDisplays
org.gnome.Notes
org.gnome.OCRFeeder
org.gnome.PasswordSafe
org.gnome.Photos
org.gnome.Rhythmbox3
org.gnome.Shotwell
org.gnome.SoundJuicer
org.gnome.Totem
org.gnome.World.PikaBackup
org.gpodder.gpodder
org.inkscape.Inkscape
org.keepassxc.KeePassXC
org.libreoffice.LibreOffice
org.mozilla.firefox
org.onlyoffice.desktopeditors
org.remmina.Remmina
org.sparkleshare.SparkleShare
work.openpaper.Paperwork

@hadess
Copy link
Author

hadess commented Mar 30, 2021

Here is a complete list of apps with --talk-name=org.gtk.vfs.*, maybe it helps

I'm fairly certain most of them don't need to talk to gvfs...

@hadess
Copy link
Author

hadess commented Mar 30, 2021

Cozy doesn't need the change:
flathub/com.github.geigi.cozy#4

DejaDup doesn't need the change:
flathub/org.gnome.DejaDup#12

Handbrake fixed in flathub/fr.handbrake.ghb@b5ac0a5

FreeCAD, timetrack, Daty, trenchboom, blastem, itopia, and thincast don't need the change.

@hfiguiere
Copy link
Contributor

org.gimp.GIMP//stable is done

hfiguiere added a commit to flathub/org.inkscape.Inkscape that referenced this issue Mar 31, 2021
- add gvfsd permissions: see flathub/flathub#2180
@hfiguiere
Copy link
Contributor

org.inkscape.Inkscape//stable is done.

@hadess
Copy link
Author

hadess commented Apr 1, 2021

(We also found that --talk-name=org.gtk.vfs did nothing because there wasn't ever a daemon with that name on the other side of the bus, I'm not sure whether folks would appreciate me filing another tracker bug ^_^)

linkmauve pushed a commit to linkmauve/org.inkscape.Inkscape that referenced this issue Apr 1, 2021
hfiguiere added a commit to flathub/com.rawtherapee.RawTherapee that referenced this issue Apr 2, 2021
@hfiguiere
Copy link
Contributor

com.rawtherapee.RawTherapee is done.

A6GibKm added a commit to A6GibKm/org.gnome.baobab that referenced this issue Apr 2, 2021
@A6GibKm
Copy link

A6GibKm commented Aug 3, 2021

Fixed in baobab: flathub/org.gnome.baobab#5
and in File Roller: flathub/org.gnome.FileRoller#13

@A6GibKm
Copy link

A6GibKm commented Aug 3, 2021

Fixed in Password Safe: flathub/org.gnome.PasswordSafe#9

@hfiguiere
Copy link
Contributor

I forgot to mention I did org.gnome.OCRFeeder during an update.

flathub/org.gnome.OCRFeeder#21

@darkdragon-001
Copy link

Pinta fixed.

hadess added a commit to flatpak/flatpak-docs that referenced this issue Feb 22, 2022
This documents the changes being tracked on Flathub at:
flathub/flathub#2180
@hadess
Copy link
Author

hadess commented Feb 25, 2022

I've added documentation at https://docs.flatpak.org/en/latest/sandbox-permissions.html#gvfs-access if anyone if still curious about the options.

tinywrkb added a commit to tinywrkb/org.gnome.GHex that referenced this issue Apr 4, 2022
This should make it possible to access GVfs resources with backend URIs.
One example is the admin backend using the admin:// URI.

References:
 - https://docs.flatpak.org/en/latest/sandbox-permissions.html#gvfs-access
 - flathub/flathub#2180
 - https://wiki.gnome.org/Projects/gvfs/backends
tinywrkb added a commit to tinywrkb/org.gnome.GHex that referenced this issue Apr 4, 2022
This should make it possible to access GVfs resources with backend URIs.
One example is the admin backend using the admin:// URI.

References:
 - https://docs.flatpak.org/en/latest/sandbox-permissions.html#gvfs-access
 - flathub/flathub#2180
 - https://wiki.gnome.org/Projects/gvfs/backends
@mwleeds
Copy link

mwleeds commented Apr 5, 2022

(We also found that --talk-name=org.gtk.vfs did nothing because there wasn't ever a daemon with that name on the other side of the bus, I'm not sure whether folks would appreciate me filing another tracker bug ^_^)

Maybe worth editing the description of this issue?

bbhtt added a commit to bbhtt/cz.zeropage.Formiko that referenced this issue Aug 13, 2022
- Add dri permission: `libEGL warning: wayland-egl: could not open
  /dev/dri/renderD128 (No such file or directory)`
ondratu pushed a commit to flathub/cz.zeropage.Formiko that referenced this issue Aug 14, 2022
- Add dri permission: `libEGL warning: wayland-egl: could not open
  /dev/dri/renderD128 (No such file or directory)`
hfiguiere added a commit to flathub/org.gnome.Totem.Devel that referenced this issue Oct 29, 2022
@bbhtt bbhtt added the tracker A big list of things to track label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracker A big list of things to track
Projects
None yet
Development

No branches or pull requests

10 participants