x264: bump to build 155

[jstebbins]

Requires NASM to build
Unified 8 and 10 bit library support
AVX-512 optimizations
Various other bug fixes and improvements

[bradleysepos]

Are we planning to merge this after release (target 1.2.0)?

[jstebbins]

Whatever you guys want. I'll still be using the system version of x264 on linux. Just thought I would get this done since it required more changes than a typical bump.

[bradleysepos]

As much as I'd like the new features, I think we should let this one soak in the nightly a bit.

[bradleysepos]

Well, that didn't do what I wanted at all.

[bradleysepos]

@jstebbins I tried GitHub's resolve conflicts tool and regret it. You may want to do a hard reset to
9547979. I don't have permissions.

[bradleysepos]

Oh hey I figured it out. Wheeeeee

[bradleysepos]

I'm updating scripts/mac-toolchain-build to add nasm.

What packages are needed on Ubuntu/Fedora? Will need to update the documentation.

[jstebbins]

A very recent version of nasm is required (2.13). Fedora 27 and Ubuntu 17.10 have it. But earlier releases do not. I think if we want to avoid pain, we should build a local copy for all platforms for the foreseeable future.

But package is called simply "nasm" in both Fedora and Ubuntu.

[bradleysepos]

Okay. I'm not a fan of the local tools and intend to remove them, just haven't gotten around to it. But that would probably be the least pain.

On Mac, x264 isn't finding nasm despite it being on my path. What a pain.

[jstebbins]

I'm ok with removing all the local tools. But it's going to increase the documentation burden. We'll have to have good detailed documentation on how to set up build environments or we'll just be repeating ourselves on the forums all the time to help people through it.

[bradleysepos]

The documentation is complete regarding dependencies for all systems we support. A script is included to build all dependencies on Mac. Local tools can die whenever we get to it.

[bradleysepos]

From x264's config.log:

checking whether nasm supports vmovdqa32 [eax]{k1}{z}, zmm0... no
Failed commandline was:
--------------------------------------------------
nasm conftest.asm  -I. -I$(SRCPATH) -DARCH_X86_64=1 -I$(SRCPATH)/common/x86/ -f macho64 -DPIC -DPREFIX  -o conftest.o
nasm: fatal: unrecognised output format `macho64' - use -hf for a list
type `nasm -h' for help
--------------------------------------------------
Failed program was:
--------------------------------------------------
vmovdqa32 [eax]{k1}{z}, zmm0
--------------------------------------------------

$ nasm -hf | grep macho64
    macho64   NeXTstep/OpenStep/Rhapsody/Darwin/MacOS X (x86_64) object files

☹️

[jstebbins]

nasm --version?

[bradleysepos]

$ nasm --version
NASM version 2.13.02 compiled on Dec 28 2017

[bradleysepos]

I think it's ignoring PATH and picking up macOS' /usr/bin/nasm. 🙃

[bradleysepos]

I added some supporting commits but still have no idea why x264 is not picking up nasm on my system.

[bradleysepos]

Looks like it actually works when cross-compiling, though I also get Unknown option --build=x86_64-apple-darwin17.3.0, ignored. The only other things that should be different are --host and --cross-prefix. ~~~I wonder whether setting --host for a non-cross build will work.~~~ Nope.

[bradleysepos]

The only way I can seem to make this work is to hard code AS="/usr/local/bin/nasm" (or wherever nasm >= 2.13 is installed) in configure. Something's amiss.

[bradleysepos]

eadfc60 should fix the old nasm problem on Mac.

[kodawah]

shouldn't you use X264_BUILD 153 to check for the new bitdepth field?
never mind I missed the last patch in the series

[bradleysepos]

I've tested with this enough that I think it's probably safe for 1.1.0 if we want to include it.

[bradleysepos]

If nasm in distros is a sticking issue, we can push it back again.

[bradleysepos]

Already have one report of HandBrake not compiling with newer system x264, so perhaps we should get this in. Can add nasm compilation notes to the developer docs.

[bradleysepos]

Merged as we need the libhb changes to support newer distros now. Will add nasm instructions to the docs shortly.