Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some configure related build warnings #2281

Merged
merged 1 commit into from Sep 8, 2019
Merged

Fix some configure related build warnings #2281

merged 1 commit into from Sep 8, 2019

Conversation

Nomis101
Copy link
Contributor

Closes #2265.

This PR will fix the warning
configure: WARNING: unrecognized options: --with-glib
fribidi droped glib dependency in 2017. fribidi/fribidi#14

The PR will fix the warning
configure: WARNING: unrecognized options: --disable-sdl
liboggs configure doesn't know about this option.

The PR suppresses the harmless but annoying warning

  : src/opus_decoder.c:37:10: warning: You appear to be compiling without optimization, if so opus will be very slow. [-W#pragma-messages]
  : # pragma message "You appear to be compiling without optimization, if so opus will be very slow."
  : 
  :          ^
  : 1 warning generated.
  :   CC       src/opus_encoder.lo

Tested on macOS 10.14.

@bradleysepos bradleysepos merged commit c3f769d into HandBrake:master Sep 8, 2019
@bradleysepos
Copy link
Contributor

Merged, thanks!

@bradleysepos bradleysepos self-assigned this Sep 8, 2019
@bradleysepos bradleysepos added this to the 1.3.0 milestone Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Fix some more warnings (a question)
2 participants