Reconnect on Failed Authentication #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See HandyHat#14 for discussion of issue
Not quite sure what is happening, so also log URL
Closed
cooperaj
reviewed
Oct 13, 2021
Comment on lines
5
to
7
| "documentation": "https://github.com/ColinRobbins/ha-hildebrandglow-dcc", | ||
| "issue_tracker": "https://github.com/ColinRobbins/ha-hildebrandglow-dcc/issues", | ||
| "codeowners": ["@handyhat","@ColinRobbins"], |
There was a problem hiding this comment.
These lines are problematic given a PR into upstream.
There was a problem hiding this comment.
Well spotted, this is now removed from the PR.
(I need it in my main branch as some people are using my fork, as HandyHat does not seem to be accepting PR's at the moment. Thus people using my fork, need to amended version to HACS updates to work.)
There was a problem hiding this comment.
This PR is pretty confused, looking again, as it mixes in a new feature too.
Now sure it’s worth fixing, as it’s been superseded by #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #14
awaitto call of failed_auth_handler, otherwise its not calledMotivation and Context
Fix fo #14
How Has This Been Tested?
Locally in test and live environments
Types of changes