Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensors for Tariff data and fix Invalid Auth #40

Closed
wants to merge 35 commits into from

Conversation

ColinRobbins
Copy link
Contributor

Description

Added sensors for Tariff data.
Merged with @totalitarian fixes for cost.
Alternative integration for M3

Motivation and Context

Enhancement

How Has This Been Tested?

Tested Locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Owner

@HandyHat HandyHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ColinRobbins, thank you so much for working on adding cost sensors and fixing the invalid auth issue.

I don't believe converting the gas to m3 is necessary anymore as Home Assistant now supports using kWh for gas in the energy dashboard, so I think those changes should be removed before merging.

@HandyHat HandyHat changed the title Add sensors for Tariff data Add sensors for Tariff data and fix Invalid Auth Oct 19, 2021
@ColinRobbins
Copy link
Contributor Author

Hello.
Great to have you back online.
I’ve made a few other bug fixes that have not yet made it into a PR.
I’ll see what you have merged, then make a new PR over the weekend to fully resync, but remove the m3 stuff.
Cheers.

@ColinRobbins
Copy link
Contributor Author

Replaced with a new PR

@ColinRobbins ColinRobbins deleted the tarif branch October 26, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants