-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haneke v1.0.0 #35
Merged
Haneke v1.0.0 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave unescaped some characters that are valid for paths but not for URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haneke v1.0.0 is a major refactoring with improvements on all fronts and minor bug fixes.
Here's a changelog. For more info check out this blog post.
New components
UIButton+Haneke
: UIButton category that reduces setting foreground or background images from network or disk to one line, likeUIImageView+Haneke
beforehand.HNKNetwortFetcher
andHNKDiskFetcher
: classes that encapsulate fetching images from network and disk respectively, making it simpler to use Haneke from any layer of your app while also providing more extension points (e.g.,HNKNetworkFetcher
can be subclassed to use a custom URL session).HNKDiskCache
: standalone disk cache for any kind of data.API Changes
HNKCache
: All asynchronous fetch operations are aptly namedfetch*
and accept success and failure blocks (instead of a single completion block).UIImageView+Haneke
:placeholderImage
parameter has been renamed toplaceholder
for brevity.UIImageView+Haneke
:hnk_cancelImageRequest
has been renamed tohnk_cancelSetImage
.HNKErrorDiskCacheMiss
has been renamed toHNKErrorImageNotFound
.HNKCacheEntity
has been renamed toHNKFetcher
and the protocol has been changed to support asynchronous image fetching.Bug fixes
Code improvements
I'll the PR open for a while in case anyone wants to play with it before the official release.