Swift 4.0 support added #421
Conversation
|
thx, can you fix the the travis configuration or the tests please ? |
|
Hello, Looks like need to add xcode_sdk: iphonesimulator10.0 Where can I change the .yml? |
|
You can add it to this PR or do an other PR
|
Destination changed to platform=iOS Simulator,name=iPhone SE,OS=10.3.1
|
On the swift 4 you might want to update travis config to use xCode 9. |
Changed to osx_image: xcode9
|
Will update tests also |
|
great, thanks @lanserxt ! |
|
@dcharbonnier all done, safe to merge |
|
@gringoireDM What version should I set? Currently set 1.1 for Xcode and 0.10.2 for pod spec. |
HanekeSwift.podspec
Outdated
| @@ -1,7 +1,7 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = 'HanekeSwift' | |||
| s.module_name = 'Haneke' | |||
| s.version = '0.10.1' | |||
| s.version = '0.10.2' | |||
There was a problem hiding this comment.
The podspec version should be the same of the project version. the issue here is that pod support has been discontinued after 0.10.2. If you wanted latest commits you had to refer to specific branches or straight to master. this is not a best practice and a new pod version should be released. Good 1.1 as project version, but here too it should change to 1.1
@dcharbonnier: Please tag master after merge and release a new pod version. This is something we cannot do, so we need you to do it.
|
No one has access to the pod account. If you want to release it you will have to change the name |
|
@dcharbonnier please do. Haneke_Swift maybe? To release new pod version is important if you want still maintain the project. |
|
Thx !! |
|
Just admit that the library is discontinued. Anyway we moved away from it. Thank you anyway. |
|
@dcharbonnier You are welcome! |
|
With people like @lanserxt I think we can say it's alive and the more people will contribute the more this project will be alive. |
|
You don't even have a Mac to test the code you are going to approve. How can you say this is a maintained project? I do understand the importance of contributions, but a pod cannot stand just on contributions. It's important that the maintainer helps as well at least with the most basic things like tagging releases, testing before merging a PR, releasing new pod versions. There are things that contributors cannot do. If you don't whish to do them either, handover the ownership of the repository or declare it unmaintained. In any case, like I said before, we already removed haneke as dependency since you are willing to approve anything that pass the travis build. We are off topic. |
|
Hoy caramba ! Cocoapods is horrible. Carthage is the only way to go. one vote! (Soon, Swift Package Manager will be here and cocoapods will finally be dead.) |
|
|
No description provided.