Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4 - Adds new feature for instant saving the note #6

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Fixes #4 - Adds new feature for instant saving the note #6

merged 1 commit into from
Sep 21, 2019

Conversation

Reza-Rajabi
Copy link

I have added a hotkeys feature to save the note instantly. I hope you like it. Please let me know if you can see anything to improve in the added feature.

Rare

@Reza-Rajabi Reza-Rajabi changed the title Adds new feature for instant saving the note Fixes #4 - Adds new feature for instant saving the note Sep 21, 2019
@Hansol-Cho Hansol-Cho merged commit 67c1017 into Hansol-Cho:master Sep 21, 2019
@cagomezr
Copy link

A clever feature, hotkeys are always appreciated, I have one small recommendation to this feature however, the way Alert affects the user flow as he is trying to write a note,as alert can demand a physical click- also some users may turn the alert system after 2 or 3 saves, so perhaps you can have a label that can flash "saved" in a bold or a flashy color, that will alert the user the note has been saved and will not stop the flow of the user input. and will not show stop the window processes.

@Reza-Rajabi
Copy link
Author

That could be a nice improvement. Thank you for bring it up and share it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants