Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide possibility to restrict local search to k best individuals #160

Merged

Conversation

jakobj
Copy link
Member

@jakobj jakobj commented Jun 29, 2020

as discussed it can be beneficial to restrict the local search to the k best performing individuals (#116). this PR implements this suggestion. as expected this decreases wallclock time when used, e.g., in the example_differential_evo_regression.py from ~57s to ~44s when running local search only for the best two individuals instead of the whole population (5 individuals).

closes #116

@jakobj jakobj added this to the 0.2.0 milestone Jun 29, 2020
@jakobj jakobj requested a review from mschmidt87 June 29, 2020 11:48
@jakobj jakobj force-pushed the enh/restrict-local-search branch 2 times, most recently from 38f9ede to e212cdd Compare June 29, 2020 12:39
Copy link
Member

@mschmidt87 mschmidt87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two comments.

cgp/ea/mu_plus_lambda.py Outdated Show resolved Hide resolved
cgp/ea/mu_plus_lambda.py Outdated Show resolved Hide resolved
cgp/ea/mu_plus_lambda.py Outdated Show resolved Hide resolved
@jakobj jakobj force-pushed the enh/restrict-local-search branch from e212cdd to daa9aaf Compare July 3, 2020 08:48
@jakobj
Copy link
Member Author

jakobj commented Jul 3, 2020

thanks for the input! 👌 addressed your comments, pls have another look

@jakobj jakobj force-pushed the enh/restrict-local-search branch from daa9aaf to 28115d9 Compare July 3, 2020 09:04
Copy link
Member

@mschmidt87 mschmidt87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mschmidt87 mschmidt87 merged commit 08ea52c into Happy-Algorithms-League:master Jul 3, 2020
@jakobj jakobj deleted the enh/restrict-local-search branch July 3, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a parameter to restrict local search to the best k individuals
2 participants