Fix bug in Node.__repr__ #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
requested changes
Aug 13, 2020
cgp/node.py
Outdated
| @@ -79,7 +79,7 @@ def idx(self) -> int: | |||
| def __repr__(self) -> str: | |||
| return ( | |||
| f"{self.__class__.__name__}(idx: {self.idx}, active: {self._active}, " | |||
| f"arity: {self._arity}, inputs {self._inputs}, output {self._output})" | |||
| f"arity: {self._arity}, inputs {self._inputs}" | |||
jakobj
approved these changes
Aug 14, 2020
| @@ -173,7 +173,7 @@ def _determine_active_nodes(self) -> Dict[int, Set[Node]]: | |||
| continue | |||
| active_nodes_by_hidden_column_idx[self._hidden_column_idx(node.idx)].add(node) | |||
|
|
|||
| for i in node.inputs: | |||
| for i in node.input_nodes: | |||
There was a problem hiding this comment.
when reading this line, i would prefer something like for input_idx in node.input_node_indices, i.e., renaming input_nodes -> input_node_indices or this overdoing it? ;)
There was a problem hiding this comment.
I think this is overdoing it. ;-)
| @@ -12,16 +12,16 @@ def test_inputs_are_cut_to_match_arity(): | |||
|
|
|||
| """ | |||
| idx = 0 | |||
There was a problem hiding this comment.
Suggested change
| idx = 0 | |
| node_idx = 0 |
There was a problem hiding this comment.
I think this is unrelated to this PR and the class member is called idx anyway.
Remove _output from repr string of Node class Rename _inputs to _input_nodes for better clarity Add test of CartesianGraph.__repr__ function Add test for __repr__ of 3 example nodes Co-authored-by: Jakob Jordan <1562742+jakobj@users.noreply.github.com>
mschmidt87
force-pushed
the
bugfix/node_repr
branch
from
a769ec3
to
10d76c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #232 by following the suggestions of @jakobj in the ticket: