-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check tournament_size <= n_parents in hl_api #268
Check tournament_size <= n_parents in hl_api #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this!
however, i would strongly suggest to have such checks not only in the high level API, but deeper in the library. i think it makes most sense in mu_plus_lambda._create_offspring_population
before doing anything else. there you have all information necessary to perform the check.
Note to myself: Address #271 within this PR |
I can move it there, but the downside is, that |
indeed, the lower you go in the code the more often you will evaluate such checks. however, in terms of runtime we will not see any effect (+1 |
1d27314
to
c12ef3f
Compare
c12ef3f
to
ecfb817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks! 👍
let's wait for travis to be happy before merging.
ecfb817
to
61595e7
Compare
61595e7
to
811df3e
Compare
Makes the sanity check that the tournament size is smaller or equal to the number of parents in a population. Closes #246
Note that this PR is not ready for merging - due to the sanity checks various examples now raise errors. (Will adapt if the concept is approved)