Minor clarification to README #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijsch
requested changes
Apr 9, 2020
| @@ -41,6 +41,7 @@ ch_cookie_consent: | |||
| ### Step 4: Configure to your needs | |||
| Configure your Cookie Consent with the following possible settings | |||
| ```yaml | |||
| # app/config.yml | |||
There was a problem hiding this comment.
For newer Symfony versions a file should automatically be created in config/packages/ch_cookie_consent.yaml, so in those cases it should not be in app/config.yml. So I rather see this be
config/packages/ch_cookie_consent.yaml
| @@ -128,7 +129,7 @@ By loading Resources/public/js/cookie_consent.js the cookie consent will be subm | |||
| You can override the templates by placing templates inside your poject: | |||
|
|
|||
| ```twig | |||
| # app/Resources/CHCookieConsentBundle/views/cookie_consent.html.twig | |||
| # app/templates/bundles/CHCookieConsentBundle/cookie_consent.html.twig | |||
There was a problem hiding this comment.
Suggested change
| # app/templates/bundles/CHCookieConsentBundle/cookie_consent.html.twig | |
| #templates/bundles/CHCookieConsentBundle/cookie_consent.html.twig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt stupid for 30 minutes after double- and triple-checking why I got exceptions when using these in the routing.yml file, it seemed so logical at the time with the
ch_cookie_consent:and all. This change might save other from the same ambiguity.