Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor clarification to README #56

Closed
wants to merge 2 commits into from
Closed

Minor clarification to README #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a3413e
Minor clarification to README
NiklasBr Apr 8, 2020
6b95bad
Updated path comment for template
NiklasBr Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ ch_cookie_consent:
### Step 4: Configure to your needs
Configure your Cookie Consent with the following possible settings
```yaml
# app/config.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For newer Symfony versions a file should automatically be created in config/packages/ch_cookie_consent.yaml, so in those cases it should not be in app/config.yml. So I rather see this be

config/packages/ch_cookie_consent.yaml

ch_cookie_consent:
theme: 'light' # light, dark
categories: # Below are the default supported categories
Expand Down Expand Up @@ -128,7 +129,7 @@ By loading Resources/public/js/cookie_consent.js the cookie consent will be subm
You can override the templates by placing templates inside your poject:

```twig
# app/Resources/CHCookieConsentBundle/views/cookie_consent.html.twig
# app/templates/bundles/CHCookieConsentBundle/cookie_consent.html.twig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# app/templates/bundles/CHCookieConsentBundle/cookie_consent.html.twig
#templates/bundles/CHCookieConsentBundle/cookie_consent.html.twig

{% extends '@!CHCookieConsent/cookie_consent.html.twig' %}

{% block title %}
Expand Down