Fix - Enemy Randomizer wrongly set flags #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
assuming this should be pointed at bradley |
Woops, thanks. |
briaguya-ai
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both redeads/gibdo's and Iron Knuckles were setting flags that overlapped with the flags already used by other objects in the game.
Notably, the web in Deku Tree would already be lit when killing an Iron Knuckle before, and killing a redead caused the "platforms dropping" cutscene when killing a redead in the central room. Spirit temple torches would be incorrectly lit, Fire Temple cracked floor would already be open before bombing it, all because of similar reasons.
Iron knuckles already were changed to use the "clear room" flag to properly despawn them in Enemy Rando, so removing this flag doesn't break anything.
I honestly couldn't even find anything in the game's code that uses this Redead flag, but they seem to work just fine in clear enemy rooms, so I'm not sure what's up with this one? Regardless, just to be safe, it's only prevented from being set in Enemy Randomizer.
Build Artifacts