gibbs -> dev #2497
Merged
gibbs -> dev #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unds in Entrance Rando (#2457) * fix market night escape to work with entrance rando; adjust HF bridge spawn to not have link fall in water at night * use scene enums for ER logic instead of magic nums * fix sun song loading are with wrong link position with grotto shuffle on * Update soh/soh/Enhancements/randomizer/randomizer_entrance.c
* fix entrance init and entrance tracker not working properly when no spoiler log is loaded * fix rando adult trade spoilable items reverting when no spoiler log loaded
In German Shiek is called Sheik (something related to how they switched letter to conserve the wanted pronunciation of the name)
Volvagia is Vulcania in french (I'm so used to it in English) and I somehow put the german version of dodongo's cavern in french, oops
Co-authored-by: briaguya <briaguya@alice>
* fix certain items being marked as major * simplify check * avoid string check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts