Hyper Enemies (act and move twice as fast) #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMannus
commented
May 12, 2023
Comment on lines
-14
to
-19
| extern void Play_PerformSave(PlayState* play); | ||
| extern s32 Health_ChangeBy(PlayState* play, s16 healthChange); | ||
| extern void Rupees_ChangeBy(s16 rupeeChange); | ||
| extern Actor* Actor_Spawn(ActorContext* actorCtx, PlayState* play, s16 actorId, f32 posX, f32 posY, f32 posZ, | ||
| s16 rotX, s16 rotY, s16 rotZ, s16 params, s16 canRandomize); | ||
| extern void Inventory_ChangeEquipment(s16 equipment, u16 value); |
There was a problem hiding this comment.
These don't need to be here because functions.h is already included. I've removed these in an earlier PR but I guess they were put back during merges, so I'm removing them here again.
leggettc18
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be pretty self explanatory. It's possible I've missed enemies that don't have the enemy category, or that there's more actors that do belong to the category but shouldn't be sped up. That said, someone has done a full playthrough with this before and they said it worked fine, and I haven't found any other disrepencies during my own testing either.
Build Artifacts