-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mask Sale Fix #2900
Mask Sale Fix #2900
Conversation
…temTable entry and trying to find it in one would always error, and also no need I can think of for anyone to know about that item in the context of the hook.
OnItemReceive
for ITEM_SOLD_OUT
, as there is no I……o `ITEM_NONE` to prevent mistyped return issues.
…returning ITEM_NONE to preserve expected autosave on mask sale while still fixing the crash. This will need to be implemented more cleanly later with story events.
Alright, this latest build does still fix it, and I feel it's the least intrusive way to handle the autosave given the fact it's intended to be temporary. |
Mainly, I just wanted to present this alternative before we went through with the ItemTable modification. We may yet decide that that needs to be done completely separate from the autosave issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, let's make an issue for event-based autosave and note that we should be able to remove this on that issue
Seems to have a merge conflict somewhere, on mobile so can't really tell where rn. |
@leggettc18 it was just the int vs uint thing, i went ahead and resolved it using the github web ui |
Figured that was probably it, I'll merge shortly |
Lol, I already made the issue for event-based saves. |
Prevent calling OnItemReceive for ITEM_SOLD_OUT, as there is no ItemTable entry and trying to find it in one would always error, and also no need I can think of for anyone to know about that item in the context of the hook.
Should fix mask sale crash on Switch.
Build Artifacts