Mask Sale Fix #2900
Merged
Mask Sale Fix #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…temTable entry and trying to find it in one would always error, and also no need I can think of for anyone to know about that item in the context of the hook.
Malkierian
changed the title
OnItemReceive for ITEM_SOLD_OUT, as there is no I…
leggettc18
requested changes
May 20, 2023
briaguya-ai
reviewed
May 20, 2023
…o `ITEM_NONE` to prevent mistyped return issues.
leggettc18
approved these changes
May 20, 2023
…returning ITEM_NONE to preserve expected autosave on mask sale while still fixing the crash. This will need to be implemented more cleanly later with story events.
|
Alright, this latest build does still fix it, and I feel it's the least intrusive way to handle the autosave given the fact it's intended to be temporary. |
|
Mainly, I just wanted to present this alternative before we went through with the ItemTable modification. We may yet decide that that needs to be done completely separate from the autosave issue. |
briaguya-ai
approved these changes
May 20, 2023
|
Seems to have a merge conflict somewhere, on mobile so can't really tell where rn. |
|
@leggettc18 it was just the int vs uint thing, i went ahead and resolved it using the github web ui |
|
Figured that was probably it, I'll merge shortly |
leggettc18
approved these changes
May 20, 2023
|
Lol, I already made the issue for event-based saves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent calling OnItemReceive for ITEM_SOLD_OUT, as there is no ItemTable entry and trying to find it in one would always error, and also no need I can think of for anyone to know about that item in the context of the hook.
Should fix mask sale crash on Switch.
Build Artifacts