Enhancement: Show Gauntlets in First Person #2918
Conversation
There was a problem hiding this comment.
Gotta say, don't love how it looks, but that's just the way the model is, nothing to do with your code. Plus a custom model pack might be able to make it look better so I'd say this is good to merge.
I left one comment about a thing I'd like to see/discuss a bit but it's not a blocker to actually merging.
| @@ -803,7 +803,9 @@ void func_8008F470(PlayState* play, void** skeleton, Vec3s* jointTable, s32 dLis | |||
|
|
|||
| SkelAnime_DrawFlexLod(play, skeleton, jointTable, dListCount, overrideLimbDraw, postLimbDraw, data, lod); | |||
|
|
|||
| if ((overrideLimbDraw != func_800902F0) && (overrideLimbDraw != func_80090440) && (gSaveContext.gameMode != 3)) { | |||
| if (((CVarGetInteger("gFPSGauntlets", 0) && LINK_IS_ADULT) || (overrideLimbDraw != func_800902F0)) && | |||
There was a problem hiding this comment.
Can this LINK_IS_ADULT check be removed to allow this to work with the Timeless Equipment cheat and equip swap? Or would that break something else or result in a really nasty if statement? Or do we think it's more consistent to not have the gauntlets when using Hookshot as child? I'm totally fine with either option, just wanted to make sure this question was considered.
There was a problem hiding this comment.
Maybe it can check for the held item instead and check for the adult first person items?
There was a problem hiding this comment.
Further discussion with some other devs has revealed that there's actually another Adult Link check further down in the authentic code. So even removing the above LINK_IS_ADULT check would still cause the gauntlets to not render when equip swapping as child, which is fine and imo should be left alone for now. That being said, the LINK_IS_ADULT check here should be unnecessary. Can it be removed @MoriyaFaith or is there a specific reason you have it here?
There was a problem hiding this comment.
If it's removed, It renders the goron bracelet on the otherwise invisible child link right arm.
leggettc18
added
the
merge conflicts
|
Looks like a merge conflict popped up here. Probably nothing difficult, @MoriyaFaith are you able to see about resolving it? |
|
should be fixed now. As for the way they look, I know it doesn't look great with default gauntlets. If anything, this was made for custom gauntlets, like my own work and the OoT3D port. |
leggettc18
added
merge ready
and removed
merge conflicts
A simple enhancement that allows the player to see Link's Gauntlets while using the Bow and Hookshot, mimicking behavior in Ocarina of Time 3D.
Build Artifacts