Fix: Cosmetic HUD placement reset position corrupting ship json #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
seems like the same pattern I used to fix another crash in #2828
Archez
force-pushed
the
fix-reset-hud-positions
branch
from
e93a04a
to
07e029f
Compare
leggettc18
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ship.json was getting corrupted upon saving after pressing the "Reset all positions" button in the hud placements section for the Cosmetic Editor.
The problem was the variable type we were assigning to was
const char*and in the assignment we were doing a call tostd::string(const char* str)this resulted in aImplicit Constructor call not supportedleading to undefined behavior when building the final CVar name.The solution is to capture the assignment as a
std:stringand performing the final.c_str()when calling the CVar method. This is how it was being done for all the other buttons here.Build Artifacts