Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the easy Quick Put Away (QPA) cheat #3268

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

DeusVexus
Copy link
Contributor

@DeusVexus DeusVexus commented Oct 6, 2023

Adds the easy Quick Put Away (QPA) cheat that gives your melee weapon the glitched damage value of the QPA glitch

Build Artifacts

@@ -1235,6 +1235,8 @@ void DrawCheatsMenu() {
UIWidgets::Tooltip("Makes every tunic have the effects of every other tunic");
UIWidgets::PaddedEnhancementCheckbox("Easy ISG", "gEzISG", true, false);
UIWidgets::Tooltip("Passive Infinite Sword Glitch\nIt makes your sword's swing effect and hitbox stay active indefinitely");
UIWidgets::PaddedEnhancementCheckbox("Easy QPA", "gEzQPA", true, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll rename this along with other cheats at some point, but we can do that all at once, at least for now this is consistent with EzISG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@DeusVexus
Copy link
Contributor Author

DeusVexus commented Oct 17, 2023

So, when I initially tested this, I just tested it on the torches outside of shadow temple and it worked great. I don't remember if I tested on any other typical qpa interactions -- I may have just assumed if one qpa interaction worked, then they all should.
After just now testing it against red ice walls, red ice rocks and a bombable wall in shadow temple, I found that it doesn't work in those instances, so I will need to refine this further.
I'm not very knowledgeable when it comes to how the sword works and its collision, etc, so if anyone has any ideas to fix this problem, feel free to let me know

@DeusVexus DeusVexus marked this pull request as draft October 17, 2023 01:26
@DeusVexus
Copy link
Contributor Author

After further investigation and testing, it appears that the "vanilla" behavior is that red ice walls and rocks and that breakable wall in shadow temple are not affected by qpa, even with the blue fire arrows enhancement (and the breakable wall in shadow temple isn't affected by blue fire arrows either)
That being the case, I believe the pr was actually working as intended all along, so I'll restore it to an open pr

@DeusVexus DeusVexus marked this pull request as ready for review October 17, 2023 03:51
@garrettjoecox garrettjoecox merged commit 743be7b into HarbourMasters:develop Oct 27, 2023
8 checks passed
@DeusVexus DeusVexus deleted the Add-Easy-QPA-Cheat branch August 31, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants