Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move thread pool initialization and
OnExitGame
registration fromSaveManager::Init()
to SM's constructor.This is necessary because
SaveManager::Init()
is merely an extension ofSram_InitSram()
, and as such is not an initializer forSaveManager
itself. Before now, every reset would add another registration forOnExitGame
and reinitialize the thread pool, which was definitely not a good thing.Also added call to
ThreadPoolWait()
inInit()
, as it was relatively easy, especially on Anchor, to trigger a save afterOnExitGame
was already processed, thus introducing the possibility thatInit()
would be loading a file (or reinitializing the thread pool, for that matter) at the same time the save worker was writing to the file, causing it to try to load incomplete and malformed save data.Build Artifacts