Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON parsing every frame on file select #3513

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Fix JSON parsing every frame on file select #3513

merged 2 commits into from
Dec 17, 2023

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Dec 11, 2023 •
edited by github-actions bot
Loading

This does a few things

  • Reverts changes to SpoilerFileExists from Race Integrity QoL #3445
  • Creates a hook for file drops
  • In order to not break things on Macready, preserve the same exact file drop process that existed previously for spoiler files, leaving TODO comments to refactor the spoiler file handling system in the future (rando v3)

Hide whitespaces recommended for the diff

Build Artifacts

@briaguya-ai briaguya-ai merged commit fcf2141 into HarbourMasters:develop-macready Dec 17, 2023
8 checks passed
@garrettjoecox garrettjoecox deleted the fix-json-parse-on-file-select branch March 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettjoecox @Archez @briaguya-ai