605-bug-fix-baseline-sherlock #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
605-bug-fix-baseline-sherlock
MattMina04
changed the title
MattMina04
changed the title
|
Hi @MattMina04, I cannot see any changes here. Can you please check and push your changes to sherlock.tsx to the branch? Kind regards Michael |
|
Oh so sorry Michael, i just pushed my changes i think. check again and let me know please
…________________________________
From: michaeljpigott ***@***.***>
Sent: Saturday, 11 May 2024 4:42 PM
To: Hardhat-Enterprises/Deakin-Detonator-Toolkit ***@***.***>
Cc: MattMina04 ***@***.***>; Mention ***@***.***>
Subject: Re: [Hardhat-Enterprises/Deakin-Detonator-Toolkit] 605-bug-fix-baseline-sherlock (PR #683)
Hi @MattMina04<https://github.com/MattMina04>, I cannot see any changes here. Can you please check and push your changes to sherlock.tsx to the branch?
Kind regards
Michael
—
Reply to this email directly, view it on GitHub<#683 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMJ32JLBWIOFJWY66MSWKSDZBW4XBAVCNFSM6AAAAABHQPQQT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGU4TONJQGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hi @MattMina04, I still cannot see any changes. Make sure you add your changes to your local branch, commit them and push them to this branch: 605-bug-fix-baseline-sherlock Good luck. Michael |
|
Hey i think i did it. can you check for me when you can please.
Thanks
…________________________________
From: michaeljpigott ***@***.***>
Sent: Monday, 13 May 2024 8:46 AM
To: Hardhat-Enterprises/Deakin-Detonator-Toolkit ***@***.***>
Cc: MattMina04 ***@***.***>; Mention ***@***.***>
Subject: Re: [Hardhat-Enterprises/Deakin-Detonator-Toolkit] 605-bug-fix-baseline-sherlock (PR #683)
Hi @MattMina04<https://github.com/MattMina04>, I still cannot see any changes. Make sure you add your changes to your local branch, commit them and push them to this branch: 605-bug-fix-baseline-sherlock
Good luck.
Michael
—
Reply to this email directly, view it on GitHub<#683 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMJ32JIFU252PHFVM3VJ2RTZB7WM7AVCNFSM6AAAAABHQPQQT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGM4TQNJTGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hi @MattMina04, I can see the changes thank you. You need to remove the following files out of your branch. Baseline bug fixes should only affect one file, the tsx file for the tool in question.
|
|
Oh sorry, just deleted them now.
…________________________________
From: michaeljpigott ***@***.***>
Sent: Saturday, 18 May 2024 3:19 PM
To: Hardhat-Enterprises/Deakin-Detonator-Toolkit ***@***.***>
Cc: MattMina04 ***@***.***>; Mention ***@***.***>
Subject: Re: [Hardhat-Enterprises/Deakin-Detonator-Toolkit] 605-bug-fix-baseline-sherlock (PR #683)
Hi @MattMina04<https://github.com/MattMina04>, I can see the changes thank you. You need to remove the following files out of your branch. Baseline bug fixes should only affect one file, the tsx file for the tool in question.
* package-lock.json
* package.json
* yarn.lock
—
Reply to this email directly, view it on GitHub<#683 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMJ32JJZOIEPKYO2N3LV5W3ZC3QG7AVCNFSM6AAAAABHQPQQT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGY2DMMZRGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
JiatengTao
added a commit
that referenced
this pull request
Jun 6, 2024
Merge code to avoid duplicated claims for future trimesters, any issue please raise a new ticket
Siddh2001
added a commit
to Siddh2001/Deakin-Detonator-Toolkit
that referenced
this pull request
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
605-bug-fix-baseline-sherlock