-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-router-redux #93
Conversation
hey @carloscuatin was checking this out and looks good. two things I noticed... In /PostContainer/PostContainer.jsx line 46 put closing tag on same line as nothing changed I believe if nodemon isn't installed globally we may have problems with 'rs' server after changes, I believe we need a nodemon.json file but can't be sure as I have it personally installed globally I just seen in other cases people having problems without having nodemon.json file settings when installed locally. check this out here for nodemon FAQ. in shared/redux/reducers/blog.js maybe we should rename this to post.js reason is maybe in future we add comments.js, user.js, etc blog.js sounds to broad of a term that could cover all these as a whole. Also we should change shared/redux/actions/actions.js to shared/redux/actions/post.js ? same concept I mentioned above for reducers we could apply to actions. Maybe this one we do on another PR cause we need to change components with no sub folders just name of file :) What sort of implementation did for refactor code and test for new features as jwt auth? are you considering that jwt auth redux library? or passport? @prank7 @mayankchd @sandeeppanda92 @carloscuatin thoughts? Nice work brother |
add react-router-redux and refactor code and test for new features as jwt auth