Change the type of differenceR to include a mandatory base shape #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first element of the list argument to `differenceR` is special, and acts as the shape from which the others are subtracted. The previous behavior of exporting `differenceR r []` (or even `differenceR [x]`) was to crash due to `head` and `tail` being partial functions. From this analysis, it's clear that the "shape to remove from" is a *mandatory* argument to `differenceR`, and as such should be explicitly moved out of the list args.
|
@julialongtin PTAL |
julialongtin
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: changes the type of
differenceRfromObject obj vec => R -> [obj] -> objtoObject obj vec => R -> obj -> [obj] -> obj.The first element of the list argument to
differenceRis special, andacts as the shape from which the others are subtracted. The previous
behavior of exporting
differenceR r [](or evendifferenceR [x]) wasto crash due to
headandtailbeing partial functions.From this analysis, it's clear that the "shape to remove from" is
a mandatory argument to
differenceR, and as such should beexplicitly moved out of the list args.
Fixes #293
Note: I don't understand how the scad parser should deal with this, so I just hammered this in there. Please take a look (right now I'm just calling
error.)