Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omolize? #3

Closed
fisx opened this issue Feb 20, 2021 · 3 comments
Closed

omolize? #3

fisx opened this issue Feb 20, 2021 · 3 comments

Comments

@fisx
Copy link

fisx commented Feb 20, 2021

I just opened this ImplicitCAD PR, and I'm hoping to find the time to open one for hslice soon.

Is that something you could get excited about? Please feel invited to the debate there.

@sorki
Copy link
Collaborator

sorki commented Feb 20, 2021

Yup, I've tried it already for one code base but didn't integrate it into my workflow, mostly used its suggestions to improve few parts but kept some hand-formatted.

Feel free to submit a PR formatted with it - I can take care of nix integration part (and possibly pre-commit hook).

@fisx
Copy link
Author

fisx commented Feb 20, 2021

Yup, I've tried it already for one code base but didn't integrate it into my workflow, mostly used its suggestions to improve few parts but kept some hand-formatted.

Feel free to submit a PR formatted with it - I can take care of nix integration part (and possibly pre-commit hook).

Great, thanks! :)

I'll submit a github workflow to Haskell-Things/ImplicitCAD#376 soon, and I'd love to hear your suggestions, then we can recycle the result here. (I wanted to hack it into ci.dhall, but that looked like it wasn't really supposed to work out of the box, or at least it would take me a lot longer to figure out.)

sorki added a commit that referenced this issue Jun 6, 2021
@sorki
Copy link
Collaborator

sorki commented Jun 6, 2021

I've formatted this with stylish-haskell (part of #5) instead which seems to fit my style a bit more and required only a few changes.

@sorki sorki closed this as completed Oct 22, 2023
sorki added a commit that referenced this issue Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants