Fix CV flag #1
Merged
Fix CV flag #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag of Cape Verde had the stripes and stars positioned too low. The top blue part is supposed to occupy half of the height of the flag. I've edited the geometry so that the white and red stripes start at 50% of height of the circle. I moved the stars upwards accordingly. See https://en.wikipedia.org/wiki/Flag_of_Cape_Verde for details.
|
Actually, I should make the stripes larger, since the bottom blue part should only occupy the lower quarter of the flag. That would also help in making the flag elements more visible at small sizes. I'll hold off on making these changes, though, until I get initial feedback on this PR. |
|
Thanks for the fix, @waldyrious! Already looks a lot better. And indeed you're right that the ratios would be more accurate if the stripes were upscaled to take up a quarter of the flag's height. You're welcome to make any further updates. :) |
|
I will submit a new PR with the additional fixes soon :) |
This was referenced Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag of Cape Verde had the stripes and stars positioned too low.
The top blue part is supposed to occupy half of the height of the flag.
I've edited the geometry so that the white and red stripes start at 50% of height of the circle. I moved the stars upwards accordingly.
See https://en.wikipedia.org/wiki/Flag_of_Cape_Verde for details.
Reference image:
