Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): prevent duplicate tx earlier #1006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Apr 25, 2024

Motivation

This verification has to happen anyway and doing it earlier avoids wasting time with more expensive verifications.

Acceptance Criteria

  • Check for tx existence on HathorManager.push_tx directly before waiting for HathorManger.on_new_tx to do it.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Apr 25, 2024
@jansegre jansegre changed the title fix(api): prevent duplicate tx earlier refactor(api): prevent duplicate tx earlier Apr 29, 2024
@jansegre jansegre marked this pull request as ready for review April 29, 2024 18:39
@jansegre jansegre requested a review from msbrogli as a code owner April 29, 2024 18:39
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (b20be70) to head (f70cdef).

Files Patch % Lines
hathor/manager.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
+ Coverage   84.87%   84.90%   +0.03%     
==========================================
  Files         300      300              
  Lines       22943    22945       +2     
  Branches     3470     3471       +1     
==========================================
+ Hits        19473    19482       +9     
+ Misses       2778     2774       -4     
+ Partials      692      689       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review (WIP)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants