Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run with nodejs instead of yarn in Dockerfile #173

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

andreabadesso
Copy link
Collaborator

Motivation

The docker image was failing to run in kubernetes because our containers there are read-only

Upon investigation, I found out that corepack and yarn needs to write to fs

This PR changes the Dockerfile to include another stage that only have node installed, copies the installed dependencies and runs the service with the pre-installed nodejs instead of using yarn to run it.

Acceptance Criteria

  • We should change the Dockerfile to be multi-stage
  • The second stage should only have nodejs installed and run the daemon using it

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Jun 13, 2024
@andreabadesso andreabadesso added the bug Something isn't working label Jun 13, 2024
@andreabadesso andreabadesso merged commit 8450aaf into master Jun 13, 2024
1 check passed
@andreabadesso andreabadesso deleted the fix/run-with-node branch June 13, 2024 16:37
This was referenced Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants