Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Ledger hardware wallet #68

Merged
merged 18 commits into from
Feb 24, 2020
Merged

feat: Add support for Ledger hardware wallet #68

merged 18 commits into from
Feb 24, 2020

Conversation

obiyankenobi
Copy link
Member

@obiyankenobi obiyankenobi commented Jan 17, 2020 •
edited
Loading

Closes #50 and #51

pedroferreira1
pedroferreira1 reviewed Jan 18, 2020
View reviewed changes
public/ledger.js Outdated Show resolved Hide resolved
@obiyankenobi obiyankenobi marked this pull request as ready for review January 18, 2020 21:31
@obiyankenobi obiyankenobi self-assigned this Jan 18, 2020
msbrogli
msbrogli requested changes Jan 29, 2020
View reviewed changes
public/electron.js Outdated Show resolved Hide resolved
public/electron.js Show resolved Hide resolved
public/electron.js Outdated Show resolved Hide resolved
src/constants.js Outdated
@@ -95,6 +95,7 @@ export const SENTRY_DSN = process.env.SENTRY_DSN || 'https://69c067d1587c465cac8
* Server options for the user to choose which one to connect
*/
export const DEFAULT_SERVERS = [
'http://localhost:8080/v1a/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove localhost from servers.

src/App.js Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/utils/wallet.js Outdated Show resolved Hide resolved
msbrogli
msbrogli requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@msbrogli msbrogli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is heavily dependent on Ledger. We will need a major refactor to add support to more hardware wallets. Anyway, I think it is good for this PR and we should refactor it in another PR. What do you think?

src/utils/ledger.js Outdated Show resolved Hide resolved
src/utils/ledger.js Show resolved Hide resolved
src/utils/ledger.js Show resolved Hide resolved
src/utils/ledger.js Show resolved Hide resolved
src/screens/SendTokens.js Outdated Show resolved Hide resolved
public/ledger.js Outdated Show resolved Hide resolved
public/ledger.js Outdated Show resolved Hide resolved
public/ledger.js Show resolved Hide resolved
public/ledger.js Show resolved Hide resolved
public/ledger.js Outdated Show resolved Hide resolved
pedroferreira1
pedroferreira1 requested changes Jan 30, 2020
View reviewed changes
src/screens/WalletType.js Outdated Show resolved Hide resolved
obiyankenobi
obiyankenobi commented Feb 3, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pedroferreira1 @obiyankenobi @msbrogli
feat: Add support for Ledger hardware wallet
ae6d8c1 
Co-authored-by: Yan Martins <yan.martins@gmail.com>
@msbrogli msbrogli changed the base branch from master to dev February 3, 2020 23:11
msbrogli
msbrogli requested changes Feb 3, 2020
View reviewed changes
src/components/OutputsWrapper.js Outdated Show resolved Hide resolved
src/components/SendTokensOne.js Outdated Show resolved Hide resolved
src/components/ModalAlertNotSupported.js Outdated Show resolved Hide resolved
src/components/ModalAlertNotSupported.js Outdated Show resolved Hide resolved
src/components/ModalAlertNotSupported.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Outdated Show resolved Hide resolved
src/screens/WalletType.js Show resolved Hide resolved
@msbrogli msbrogli changed the title feat: Ledger support feat: Add support for Ledger hardware wallet Feb 3, 2020
msbrogli
msbrogli reviewed Feb 4, 2020
View reviewed changes
ELECTRON.md Show resolved Hide resolved
@obiyankenobi obiyankenobi mentioned this pull request Feb 4, 2020
Closed
This was referenced Feb 4, 2020
Closed
Closed
@obiyankenobi obiyankenobi linked an issue Feb 4, 2020 that may be closed by this pull request
Support for new software wallet UX #50
Closed
2 tasks
@obiyankenobi obiyankenobi linked an issue Feb 4, 2020 that may be closed by this pull request
Support for hardware wallet #51
Closed
5 tasks
@obiyankenobi obiyankenobi merged commit ceb8940 into dev Feb 24, 2020
@obiyankenobi obiyankenobi deleted the feat/ledger-comunication branch February 24, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbrogli msbrogli msbrogli approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@obiyankenobi obiyankenobi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for hardware wallet Support for new software wallet UX
3 participants
@obiyankenobi @msbrogli @pedroferreira1