Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor to use python healthcheck lib #105

Merged
merged 3 commits into from
Nov 27, 2023
Merged

chore: refactor to use python healthcheck lib #105

merged 3 commits into from
Nov 27, 2023

Conversation

luislhl
Copy link
Contributor

@luislhl luislhl commented Oct 24, 2023 •
edited
Loading

Acceptance Criteria

We should refactor the former healthcheck logic to use the new healthcheck lib we've built in https://github.com/HathorNetwork/python-healthcheck-lib

TODO

  • The lib is being installed directly from the Git repo to make sure we can test it. But we should install it from PyPI when it's available there.

@luislhl luislhl self-assigned this Oct 24, 2023
@luislhl luislhl force-pushed the chore/refactor-python-healthchecklib branch from 8240cf8 to 159119b Compare October 25, 2023 22:33
@luislhl luislhl marked this pull request as ready for review November 9, 2023 21:40
@luislhl luislhl removed the request for review from msbrogli November 9, 2023 21:40
@luislhl luislhl changed the title chore: refactor python healthcheck lib chore: refactor to use python healthcheck lib Nov 9, 2023
glevco
glevco approved these changes Nov 16, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@luislhl luislhl merged commit 0d10536 into dev Nov 27, 2023
2 checks passed
@luislhl luislhl deleted the chore/refactor-python-healthchecklib branch November 27, 2023 16:52
This was referenced Nov 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansegre jansegre jansegre approved these changes

@glevco glevco glevco approved these changes

Assignees

@luislhl luislhl

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luislhl @jansegre @glevco