feat: health check #104
Merged
feat: health check #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislhl
requested review from
glevco and
pedroferreira1
and removed request for
msbrogli and
pedroferreira1
luislhl
force-pushed
the
feat/health-check
branch
from
8f36860
to
dec49b0
Compare
glevco
reviewed
Oct 4, 2023
glevco
reviewed
Oct 5, 2023
glevco
approved these changes
Oct 5, 2023
tuliomir
approved these changes
Oct 11, 2023
txstratum/healthcheck/healthcheck.py
Outdated
| health_check = ComponentHealthCheck( | ||
| component_name=self.COMPONENT_NAME, | ||
| component_type=ComponentType.FULLNODE, | ||
| # TODO: Ideally we should not use private fields. We'll fix this when fixing line 170 |
There was a problem hiding this comment.
I'd suggest naming the feature/command that is currently on line 170, as the line can change on maintenance PRs.
luislhl
commented
Oct 16, 2023
Co-authored-by: Tulio Miranda <tulio.mir@gmail.com>
luislhl
force-pushed
the
feat/health-check
branch
from
20d55c5
to
d1b591b
Compare
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
We should have a new
/healthendpoint, that will implement a more complex health check which includes:/v1a/versionendpoint is responding. In future PRs we will use the new yet-to-be-implemented/v1a/healthendpoint of hathor-core.