-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy v1-beta1 #87
Merged
Deploy v1-beta1 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if transfer recipient already wears hat
Fix transfer to balance bug
…bility Feat: prevent transfer of immutable hats
Change hat tree shape to 14 levels with 16 bits per level
This feature allows for the following: - effectively infinitely deep trees (really, limited to 255 levels) - migrating suborgs into parent orgs without changing hat Ids A few todos left: - [ ] figure out the naming semantics for linked tophats and other naming nuances. Should we just call them "tree roots" when linked? - [ ] test the new Hats.sol functions - [ ] Add more compreshensive testing to the HatsIdUtils changes - [ ] Add test for circular linkages and safe depth
These bitshifts are cheaper to just hardcode as a single op than throw in an extra utility and add addtional contextual "jump" opcodes
Code and gas optimizations for v1
Request and approval flow for tophat links
Further code cleanup and docs
Feat: enable tophats to change their own `details` and `imageURI`
nintynick
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reviewed this changes in depth in the develop branch - good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.