-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting build number (CFBundleVersion) as integer, xcode expecting a string #159
Comments
I found this as well and consider it a bug. This broke my app build and crashed the app upon launch. The worst part was that Xcode didn't quite catch it and thus it took me hours to figure out that it even was related to this issue. I hope we can get this fixed because I consider the idea of syncing the version number with this plugin to be a great idea. |
I just tried to figure out the code and I think I could propose a pull request, but wonder if it @HausennTechnologies would consider it since this issue has not gotten any attention? Mostly it seems the input values have to be adjusted or the capacitor-set-version/src/utils.ts Line 82 in 6173198
|
Would love to see this fixed as well. |
Hello guys. @chrisspiegl that is right, just casting it to string is enough. Also, any PR are welcome. For this one, I'll fix it today. Thanks |
## [1.3.32](v1.3.31...v1.3.32) (2021-12-15) ### Bug Fixes * ios build number as string ([bb74e22](bb74e22)), closes [#159](#159)
🎉 This issue has been resolved in version 1.3.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This should be fixed now. |
Tested, seems to be working. |
Setting the version like this:
sets the CFBundleVersion to an
<integer>1234</integer>
, but XCode complains until you change this back to a<string>1234</string>
.Is this expected or a bug?
I'd guess something is parsing the build number as a JS number and the plist library is applying the property value based on type.
The text was updated successfully, but these errors were encountered: