Skip to content

Commit

Permalink
build: add version-specific library path for AIX
Browse files Browse the repository at this point in the history
Add the version-specific directory containing the C/C++ runtime
libraries to `-blibpath` on AIX. This will help link `node` against
the correct libraries at run-time when compiled with a different
version of the GNU C/C++ compiler without having to manually set
a `LIBPATH` environment variable.

PR-URL: nodejs#53585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
  • Loading branch information
richardlau committed Jun 27, 2024
1 parent 3036066 commit f1db816
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,9 @@
'-Wl,-brtl',
],
}, { # else it's `AIX`
'variables': {
'gcc_major': '<!(<(python) -c "import os; import subprocess; CXX=os.environ.get(\'CXX\', \'g++\'); subprocess.run([CXX, \'-dumpversion\'])")'
},
# Disable the following compiler warning:
#
# warning: visibility attribute not supported in this
Expand All @@ -589,7 +592,7 @@
# out more relevant warnings.
'cflags': [ '-Wno-attributes' ],
'ldflags': [
'-Wl,-blibpath:/usr/lib:/lib:/opt/freeware/lib/pthread/ppc64',
'-Wl,-blibpath:/usr/lib:/lib:/opt/freeware/lib/gcc/powerpc-ibm-aix7.3.0.0/>(gcc_major)/pthread/ppc64:/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/>(gcc_major)/pthread/ppc64:/opt/freeware/lib/pthread/ppc64',
],
}],
],
Expand Down

0 comments on commit f1db816

Please sign in to comment.