Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish up demos #287

Open
16 of 38 tasks
Geokureli opened this issue Sep 19, 2021 · 8 comments
Open
16 of 38 tasks

Polish up demos #287

Geokureli opened this issue Sep 19, 2021 · 8 comments

Comments

@Geokureli
Copy link
Member

Geokureli commented Sep 19, 2021

Some demos aren't meant for html5, others seem like they weren't verified on html5. I'd like to compile a list of quick fixes that could make the demo page look a little better

de-list the website's demos that showcase features for flash or some other target. if we can do this automatically, that'd be good but I'd like to check them all individually to see if they are easily fixed

Fix demos with issues on html5

increase window size of small demos, we can double the window size and keep the FlxGame to the same dimesnions

Misc. fixes

@ninjamuffin99
Copy link
Member

As far as I've tested, flixius seems to work fine on HTML5. The one issue I had when running locally is that the preloader didn't really like "hit.png". That's because it was actually picked up by my adblocker, and it was blocked from loading.

@ninjamuffin99
Copy link
Member

ninjamuffin99 commented Mar 10, 2022

The Save demo can be fixed by creating an array, and then setting the save data to that array.

old (throws this._gameSave.data.boxPositions[a] is undefined or can't convert undefined to object)

_gameSave.data.boxPositions = new Array();

for (box in _boxGroup)
{
	_gameSave.data.boxPositions.push(FlxPoint.get(box.x, box.y));
}

working

var boxPositions = new Array();

for (box in _boxGroup)
{
	boxPositions.push(FlxPoint.get(box.x, box.y));
}

_gameSave.data.boxPositions = boxPositions;

An assumption I'd make is that maybe along the way there was some Haxe update that changed the way you'd access and modify Dynamic variables? Not so sure on that though. Just what's in my brain right now

PR #294

@ninjamuffin99
Copy link
Member

just from testing locally, i think the Transitions demo works on HTML5? Was there a specific error?

@ninjamuffin99
Copy link
Member

Also I believe FlxBitmapText seems to be broken? I just get black screen after the splash screen

@Geokureli
Copy link
Member Author

Also I believe FlxBitmapText seems to be broken? I just get black screen after the splash screen

Fixed via HaxeFlixel/flixel#3029

@SeiferTim
Copy link
Member

As far as I've tested, flixius seems to work fine on HTML5. The one issue I had when running locally is that the preloader didn't really like "hit.png". That's because it was actually picked up by my adblocker, and it was blocked from loading.

This cost me HOURS of lost time trying to figure out why something wouldn't load because I had a file named "boomerang.png" in it.

@ninjamuffin99
Copy link
Member

The bug with FlxSpriteFilters demo where they fly off screen has a fix in this PR
(drop shadow still looks wonky, but can put that as a new task)
#349

@ninjamuffin99
Copy link
Member

also, anyone opposed to renaming the FlxSpriteFilters demo to FlxFilterFrames?
There exists no class actually named FlxSpriteFilters (the demo page claims there is one!), the main class used in the demo is FlxFilterFrames, I even mistakenly referred to it as FlxFilterFrames demo in my PR lol !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants