Treat tiles < 0 as 0 for compatibility with certain map formats (like ogmo) #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,7 +229,8 @@ class FlxBaseTilemap<Tile:FlxObject> extends FlxObject | |||
|
|
|||
| if (curTile < 0) | |||
| { | |||
| throw 'Negative values ($curTile) for tile indices are not allowed.'; | |||
| // anything < 0 should be treated as 0 - allows compatibility with certain map formats | |||
There was a problem hiding this comment.
Hm... last time I tried Ogmo I didn't see any negative indices, however, I've seen .oel data with them..
|
I guess this might be a better way to handle things then.. as long as negative values also always mean "no tile". |
Gama11
added a commit
that referenced
this pull request
Jun 9, 2014
Treat tiles < 0 as 0 for compatibility with certain map formats (like ogmo)
|
At first glance, all of my maps have -1 for 'empty' tiles... and I just now realized why that is... even though I have my '0'th tile empty, I didn't paint with it at all... if that makes sense... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.