Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxTouch / FlxSwipe / FlxMouseButton uses Float for ticks #2071

Closed
Gama11 opened this issue May 18, 2017 · 0 comments
Closed

FlxTouch / FlxSwipe / FlxMouseButton uses Float for ticks #2071

Gama11 opened this issue May 18, 2017 · 0 comments
Milestone

Comments

@Gama11
Copy link
Member

Gama11 commented May 18, 2017

...even though ticks is an integer value. In theory, this could result in a loss of precision. In practice, ticks probably never gets big enough for that (not that I've done the math).

Looks like this is my fault - the original PR used Int for ticks: https://github.com/HaxeFlixel/flixel/pull/844/files#diff-ce309ba9294449fb970f15695e2127beR40

My PR, which was based on that one, used Float:
https://github.com/HaxeFlixel/flixel/pull/848/files#diff-68555b97d9c773e556d0e4a7c4cd960cR29

Cleaning this up shouldn't be a breaking change, since you can just assign an Int value to a Float (which is ironically probably also why this happened in the first place).

@Gama11 Gama11 added the Bug label May 18, 2017
@Gama11 Gama11 added this to the 4.3.0 milestone May 18, 2017
@Gama11 Gama11 closed this as completed in 5180a83 May 18, 2017
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this issue Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant