Amf3 utf8 fixes #96
Merged
Amf3 utf8 fixes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from being faster & simpler, this also fixes the current Writer which is broken for multi-byte chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current amf3
Writeris broken for multibyte chars (it needs to write the length in bytes, not chars). This PR:adds a utf8 test for amf3
Changes the
Writerto use haxe4's native utf8 (simpler, faster and correct)I didn't touch the haxe3 implementation cause I'm not sure what is the best way to fix it, and anyone who seriously needs multibyte support should move to haxe4 anyway. The test passes for both haxe3 & haxe4, because it tests multibyte chars only under haxe4.