Skip to content

Commit

Permalink
[php7] test for #6838
Browse files Browse the repository at this point in the history
  • Loading branch information
RealyUniqueName committed Feb 5, 2018
1 parent a4f94a1 commit 16a1e34
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion extra/haxelib_src
Submodule haxelib_src updated 52 files
+1 βˆ’2 .dockerignore
+42 βˆ’63 .travis.yml
+8 βˆ’10 Dockerfile
+0 βˆ’13 Dockerrun.aws.json
+2 βˆ’2 README.md
+2 βˆ’1 appveyor.yml
+1 βˆ’0 client_tests.hxml
+1 βˆ’0 integration_tests.hxml
+ βˆ’ run.n
+1 βˆ’0 server_api.hxml
+1 βˆ’0 server_each.hxml
+1 βˆ’1 server_tests.hxml
+14 βˆ’3 src/Package.hx
+1 βˆ’0 src/haxelib/Data.hx
+1 βˆ’0 src/haxelib/SiteApi.hx
+1 βˆ’1 src/haxelib/Validator.hx
+13 βˆ’4 src/haxelib/client/FsUtils.hx
+61 βˆ’12 src/haxelib/client/Main.hx
+2 βˆ’2 src/haxelib/client/Vcs.hx
+1 βˆ’1 src/legacyhaxelib/Main.hx
+10 βˆ’3 src/website/controller/HomeController.hx
+1 βˆ’0 src/website/controller/ProjectController.hx
+9 βˆ’9 src/website/homepage-example.txt
+16 βˆ’4 test/IntegrationTests.hx
+133 βˆ’36 test/RunCi.hx
+2 βˆ’3 test/WebsiteTests.hx
+2 βˆ’1 test/docker-compose-dev.yml
+2 βˆ’1 test/docker-compose.yml
+7 βˆ’7 test/tests/integration/TestDev.hx
+3 βˆ’2 test/tests/integration/TestInfo.hx
+5 βˆ’4 test/tests/integration/TestList.hx
+3 βˆ’2 test/tests/integration/TestSet.hx
+3 βˆ’2 test/tests/integration/TestSimple.hx
+3 βˆ’2 test/tests/integration/TestUpdate.hx
+3 βˆ’2 test/tests/integration/TestUpgrade.hx
+2 βˆ’1 test/tests/integration/TestUser.hx
+1 βˆ’1 test/website/controller/HomeControllerTest.hx
+156 βˆ’0 www/css/haxe-nav.css
+113 βˆ’65 www/css/style.css
+7 βˆ’7 www/documentation-files/using-haxelib.md
+ βˆ’ www/img/haxe-logo.png
+39 βˆ’103 www/img/haxe-logo.svg
+2 βˆ’2 www/view/documentation/documentationPage.html
+81 βˆ’22 www/view/home/homepage.html
+16 βˆ’8 www/view/home/search.html
+10 βˆ’19 www/view/home/tagList.html
+40 βˆ’0 www/view/home/tagProjectList.html
+48 βˆ’79 www/view/layout.html
+1 βˆ’1 www/view/project/docs.html
+1 βˆ’1 www/view/project/file.html
+6 βˆ’6 www/view/project/version.html
+3 βˆ’3 www/view/project/versionList.html
2 changes: 1 addition & 1 deletion libs
Submodule libs updated 103 files
12 changes: 12 additions & 0 deletions tests/unit/src/unit/issues/Issue6838.hx
@@ -0,0 +1,12 @@
package unit.issues;

class Issue6838 extends unit.Test {
function test() {
var o = new Object();
eq('unit.issues._Issue6838.Object', Type.getClassName(Type.getClass(o)));
}
}

private class Object {
public function new() {}
}

7 comments on commit 16a1e34

@andyli
Copy link
Member

@andyli andyli commented on 16a1e34 Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errrr... haxelib is also reverted here...

@andyli
Copy link
Member

@andyli andyli commented on 16a1e34 Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there is #6844 too... Let's fix it and release 3.4.7 then...

@RealyUniqueName
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe i should just stop commiting without PRs...

@andyli
Copy link
Member

@andyli andyli commented on 16a1e34 Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just stop using the -a flag during git commit or use a GUI like SourceTree which shows you the staged files during commit. ;)

@RealyUniqueName
Copy link
Member Author

@RealyUniqueName RealyUniqueName commented on 16a1e34 Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Haxelib is not reverted, but rewinded by ~100 commits forward.
Changes: HaxeFoundation/haxelib@eeac8f4...a494d8b

@andyli
Copy link
Member

@andyli andyli commented on 16a1e34 Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. That's ok then. I guess we can keep it as is.

@jonasmalacofilho
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a GUI like SourceTree which shows you the staged files during commit

You can also git commit -v for an equivalent on the CLI.

Please sign in to comment.